Skip to content

docs: Add Nuxt 3 example for openapi-fetch #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

HasutoSasaki
Copy link
Contributor

@HasutoSasaki HasutoSasaki commented May 25, 2025

Changes

Add Nuxt example for openapi-fetch

How to Review

Docs change at the example section

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@HasutoSasaki HasutoSasaki requested a review from a team as a code owner May 25, 2025 07:56
@HasutoSasaki HasutoSasaki requested a review from gzm0 May 25, 2025 07:56
Copy link

netlify bot commented May 25, 2025

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e1d53fb

Copy link

changeset-bot bot commented May 25, 2025

⚠️ No Changeset found

Latest commit: e1d53fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gzm0
Copy link
Contributor

gzm0 commented May 27, 2025

Thank you very much for taking the time to contribute to openapi-fetch!

We are currently discussing among the maintainers whether we still want to increase the number of examples.
I realize the documentation actively invites new examples and in that sense is quite misleading. Apologies for that.

I have opened #2339 on which I hope we can discuss whether we should add more examples or not. Once we reach a decision there, I'll either proceed to review this PR or (unfortunately) reject it. (you are welcome to chime in in the discussion if you would like to).

@HasutoSasaki
Copy link
Contributor Author

@gzm0
Thank you for confirming!
We would be happy to participate in the discussion!

@HasutoSasaki
Copy link
Contributor Author

@gzm0

I apologize for the delay.
I created a commit to delete the example I had created, but should I add a link to my example repository in the docs after deleting the commit with force-push?

I am inexperienced and am having trouble, so I would appreciate your help.

@gzm0
Copy link
Contributor

gzm0 commented Jul 21, 2025

I created a commit to delete the example I had created, but should I add a link to my example repository in the docs after deleting the commit with force-push?

Yes, you can add an additional commit adding a link to the example.

If it is easier for you, you can also start fresh and open a completely new PR, referencing this one (and close the old one).

When we merge a PR, we squash the commits. This means your original commits will be replaced with a single, new commit. So only the final changes matter, not the history how we got there.

@HasutoSasaki HasutoSasaki deleted the nuxt-example branch July 21, 2025 13:22
@HasutoSasaki
Copy link
Contributor Author

HasutoSasaki commented Jul 21, 2025

@gzm0
That was very helpful!
We will restructure our PR and work on it here.
#2381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants